Re: [PATCH 07/10] t3200: prepare for `main` being shorter than `master`

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Oct 22, 2020, 13:08 UTC
Message-ID: <nycvar.QRO.7.76.6.2010221505320.56@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqqh7qn431p.fsf@gitster.c.googlers.com>

Hi Junio,

On Wed, 21 Oct 2020, Junio C Hamano wrote:

Show 13 quoted lines

> "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
> writes:
>
> > From: Johannes Schindelin <johannes.schindelin@gmx.de>
> >
> > In the test case adjusted by this patch, we want to cut just after the
> > longest shown ref name. Since `main` is shorter than `master`, we need
> > to decrease the number of characters. Since `main2` is shown, too, and
> > since that is only one character shorter than `master`, we decrement the
> > length by one.
>
> Confused.  I do not see 'main2' (or 'master2' for that matter) in
> the test script.

Oops. Yes, this is a left-over from the time when I had renamed the branches from `master2` to `main2` (and based on your advice, I had changed those patches to rename to `topic` instead).

> If we rename 'topic' to 'topico', then we'd still show branches, the
> longest among which has 6 characters (the same as 'master'), so we
> won't have to wonder where 'main2' came from; I guess that is another
> way to solve this.

Sure, but then, that would adjust a perfectly nice name to a not-so-nice name just to avoid changing the number of columns to cut.

If you don't mind, I would like to stay on `topic` ;-)

Ciao, Dscho