Re: Trailers Containing Underscore or Dot Characters
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 18, 2024, 01:07 UTC
- Message-ID
- <xmqqy11hjqnk.fsf@gitster.g>
- In-Reply-To
- <Zzb7aI2C2uh_nwuc@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 17 quoted lines
> The second thing we should be fixing is that git-interpret-trailers(1) > allows us to add invalid trailers: > > $ touch file > $ git interpret-trailers --in-place file --trailer 'Valid-trailer: bar' > $ git interpret-trailers --parse file > Valid-trailer: bar > $ git interpret-trailers --in-place file --trailer 'Invalid_trailer: bar' > $ git interpret-trailers --parse file > $ cat file > > Valid-trailer: bar > Invalid_trailer: bar: > > After the second invocation of git-interpret-trailers(1) it is unable to > find any trailers anymore due to the bogus format of the second trailer > line.
A good point. Thanks.