From: Junio C Hamano Date: Mon, 18 Nov 2024 01:07:27 GMT Subject: Re: Trailers Containing Underscore or Dot Characters Message-ID: In-Reply-To: Patrick Steinhardt writes: > The second thing we should be fixing is that git-interpret-trailers(1) > allows us to add invalid trailers: > > $ touch file > $ git interpret-trailers --in-place file --trailer 'Valid-trailer: bar' > $ git interpret-trailers --parse file > Valid-trailer: bar > $ git interpret-trailers --in-place file --trailer 'Invalid_trailer: bar' > $ git interpret-trailers --parse file > $ cat file > > Valid-trailer: bar > Invalid_trailer: bar: > > After the second invocation of git-interpret-trailers(1) it is unable to > find any trailers anymore due to the bogus format of the second trailer > line. A good point. Thanks.