git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] merge-ours: drop USE_THE_REPOSITORY_VARIABLE

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 6, 2026, 17:33 UTC
Message-ID
<xmqqy0l5g4kw.fsf@gitster.g>
In-Reply-To
<aYYCesJsZMdHu1Ia@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 9 quoted lines
>> -		   struct repository *repo UNUSED)
>> +		   struct repository *repo)
>>  {
>>  	show_usage_if_asked(argc, argv, builtin_merge_ours_usage);
>
> One important part of the puzzle here is that git-merge-ours(1) cannot
> run outside of a repository, as it is tagged with `RUN_SETUP`. So as a
> consequence, `repo` will never be `NULL`, and thus all the changes to
> s/the_repository/repo/ are safe.

Indeed. It may be worth recording that reasoning in the log message.

Previous: Patrick SteinhardtNext: Sam Bostock via GitGitGadget
Message 4 of 11 in “merge-ours: sparse-index integration”
  1. 0/2 merge-ours: sparse-index integrationSam Bostock via GitGitGadget, Feb 6, 2026
  2. 1/2 merge-ours: drop USE_THE_REPOSITORY_VARIABLESam Bostock via GitGitGadget, Feb 6, 2026
  3. Patrick SteinhardtFeb 6, 2026
  4. Junio C HamanoFeb 6, 2026
  5. 2/2 merge-ours: integrate with sparse-indexSam Bostock via GitGitGadget, Feb 6, 2026
  6. Junio C HamanoFeb 6, 2026
  7. 0/2 merge-ours: sparse-index integrationSam Bostock via GitGitGadget, Feb 6, 2026
  8. 2/2 merge-ours: integrate with sparse-indexSam Bostock via GitGitGadget, Feb 6, 2026
  9. 1/2 merge-ours: drop USE_THE_REPOSITORY_VARIABLESam Bostock via GitGitGadget, Feb 6, 2026
  10. Patrick SteinhardtFeb 9, 2026
  11. Derrick StoleeFeb 10, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.