Re: [PATCH 3/3] t5551: pack refs after creating many tags
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 28, 2026, 21:25 UTC
- Message-ID
- <xmqqy0fy1hnf.fsf@gitster.g>
- In-Reply-To
- <20260628080710.GC107826@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 6 quoted lines
> So let's follow that recommendation and pack the refs ourselves. > Unfortunately, this does not seem to produce an improvement to the > run-time of the test script! That's because after producing this state, > we perform only a few fetches of it. And packing the refs costs at least > as much as serving a ref advertisement (both have to iterate the refs, > but packing additionally must write .lock files as we pack).
Testing a pathological set-up with too many loose refs may have extra value, as long as we are also testing the recommended set-up, so ideally we should have both ;-) but if we have to pick only one and drop the other, we probably should be testing the packed case.
> I'm iffy on whether this one is worth it.
I am ambivalent, too, about this change for the purpose of the "yeek, apache times out while enumerating refs" issue. But see above ;-)