git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/3] fixing expensive http test timeouts

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 29, 2026, 14:39 UTC
Message-ID
<xmqqldbxz9z4.fsf@gitster.g>
In-Reply-To
<akIfsaVMB_S6kfJQ@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
> By the way, the only reason why we at GitLab haven't been feeling the
> pain is that we only enable GIT_TEST_LONG for GitHub. So I was wondering
> whether we want to have something like the below patch on top.

If we can afford the cycles, it would be good to have similarly larger coverage on two different platforms (compared to leaving one of them not doing as much as the other when we know it). On the other hand, if we cannot cover _everything_ in one platform, it may be a better use of the resources to have the other platform things that are not covered already. I see that among different pipeline sources, we are doing TEST_LONG for pull requests to any branch, and pushes only to "cast in stone" branches. If there are other branches that deserve to be tested with TEST_LONG upon other events that the existing GitHub Actions CI does not trigger, it may be good to have GitLab CI cover them, perhaps?

Show 45 quoted lines
>
> Patrick
>
> diff --git a/ci/lib.sh b/ci/lib.sh
> index b939110a6e..57801586aa 100755
> --- a/ci/lib.sh
> +++ b/ci/lib.sh
> @@ -215,6 +215,14 @@ then
>  	test macos != "$CI_OS_NAME" || CI_OS_NAME=osx
>  	CI_REPO_SLUG="$GITHUB_REPOSITORY"
>  	CI_JOB_ID="$GITHUB_RUN_ID"
> +
> +	case "$GITHUB_EVENT_NAME" in
> +	pull_request)
> +		CI_EVENT=pull_request;;
> +	push)
> +		CI_EVENT=push;;
> +	esac
> +
>  	CC="${CC_PACKAGE:-${CC:-gcc}}"
>  	DONT_SKIP_TAGS=t
>  	handle_failed_tests () {
> @@ -239,6 +247,13 @@ then
>  	CI_BRANCH="$CI_COMMIT_REF_NAME"
>  	CI_COMMIT="$CI_COMMIT_SHA"
>  
> +	case "$CI_PIPELINE_SOURCE" in
> +	merge_request_event)
> +		CI_EVENT=pull_request;;
> +	push)
> +		CI_EVENT=push;;
> +	esac
> +
>  	case "$OS,$CI_JOB_IMAGE" in
>  	Windows_NT,*)
>  		CI_OS_NAME=windows
> @@ -319,7 +334,7 @@ export SKIP_DASHED_BUILT_INS=YesPlease
>  # enable "expensive" tests for PR events.
>  # In order to catch bugs introduced at integration time by mismerges,
>  # enable the long tests for pushes to the integration branches as well.
> -case "$GITHUB_EVENT_NAME,$CI_BRANCH" in
> +case "$CI_EVENT,$CI_BRANCH" in
>  pull_request,*|push,*next*|push,*master*|push,*main*|push,*maint*)
>  	export GIT_TEST_LONG=YesPlease
>  	;;
Previous: Patrick SteinhardtNext: Patrick Steinhardt
Message 35 of 42 in “Re: [RFH] Why do osx CI jobs so unreliable?”
  1. Michael MontalboJun 20, 2026
  2. Jeff KingJun 21, 2026
  3. Patrick SteinhardtJun 22, 2026
  4. Patrick SteinhardtJun 22, 2026
  5. Patrick SteinhardtJun 22, 2026
  6. Patrick SteinhardtJun 22, 2026
  7. Michael MontalboJun 26, 2026
  8. Jeff KingJun 26, 2026
  9. Patrick SteinhardtJun 26, 2026
  10. Junio C HamanoJun 26, 2026
  11. Michael MontalboJun 26, 2026
  12. 0/3 fixing expensive http test timeoutsJeff King, Jun 28, 2026
  13. 1/3 t/lib-httpd: bump apache timeoutJeff King, Jun 28, 2026
  14. Michael MontalboJul 2, 2026
  15. 2/3 t5551: put many-tags case into its own repoJeff King, Jun 28, 2026
  16. Junio C HamanoJun 28, 2026
  17. Jeff KingJun 29, 2026
  18. Junio C HamanoJun 29, 2026
  19. Jeff KingJun 29, 2026
  20. 3/3 t5551: pack refs after creating many tagsJeff King, Jun 28, 2026
  21. Junio C HamanoJun 28, 2026
  22. Patrick SteinhardtJun 29, 2026
  23. Jeff KingJun 29, 2026
  24. Patrick SteinhardtJun 30, 2026
  25. Jeff KingJun 30, 2026
  26. weird quadratic reftable behavior, was: Re: [PATCH 3/3] t5551: pack refs after creating many tagsJeff King, Jun 30, 2026
  27. Patrick SteinhardtJul 1, 2026
  28. Jeff KingJul 1, 2026
  29. Kristofer KarlssonJul 1, 2026
  30. Patrick SteinhardtJul 1, 2026
  31. Kristofer KarlssonJul 3, 2026
  32. Patrick SteinhardtJul 6, 2026
  33. Kristofer KarlssonJul 6, 2026
  34. Patrick SteinhardtJun 29, 2026
  35. Junio C HamanoJun 29, 2026
  36. Patrick SteinhardtJun 29, 2026
  37. Junio C HamanoJun 29, 2026
  38. Patrick SteinhardtJun 30, 2026
  39. Junio C HamanoJun 30, 2026
  40. Patrick SteinhardtJul 1, 2026
  41. Jeff KingJun 26, 2026
  42. Junio C HamanoJun 22, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.