Re: [PATCH v3 1/4] mergesort: move sorting tests to Clar

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 11, 2026, 07:07 UTC
Message-ID: <xmqqy0c4emvk.fsf@gitster.g>
In-Reply-To: <21f46a2c9046d1da68233467bafb4b69226f35e6.1791556668.git.dilsheddilu123@gmail.com>

Muhammed Dilshad A <dilsheddilu123@gmail.com> writes:

> The numeric sorting tests only use mergesort.h. Move them from test-tool
> to Clar, keeping the same inputs and checks for sorted order, stable
> ordering of equal values, and list length.

The above I can parse, I know what these words mean, yet I do not think I understand what the sentences want to say. What is the point of saying the first sentence, for example? Is it the reason why "Move them ... to Clar" is a good idea? Is it what allows us to "Move them ... to Clar" (in other words, if the tests used more than just mergesort.h, moving to Clar would have been impossible)?

Show 8 quoted lines

> Store the list items in an array so cleanup can free them even if the
> sort leaves the links broken.
>
> Remove t0071 and the helper's generate and test commands. Keep the sort
> command for p0071 for now.
>
> Suggested-by: Patrick Steinhardt <ps@pks.im>
> Signed-off-by: Muhammed Dilshad A <dilsheddilu123@gmail.com>