Re: [PATCH] test-mergesort: plug memory leaks in sort_stdin()

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 7, 2026, 17:27 UTC
Message-ID: <xmqqzewp8lqw.fsf@gitster.g>
In-Reply-To: <asXi-1RlWhqPMWjL@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

> I was briefly wondering whether we could get rid of t0071 altogether in
> favor of converting the tests into a unit test, and then drop the test
> helper. And that's certainly doable, and I'd argue it would also be the
> right thing to do.

Yup, unlike any "test-tool" feature that is specific to some Git operation, things like mergesort does not need to be part of end-to-end t[0-9]{4}-*.sh test suite.

> But anyway, that's of course a much bigger scope, and I'm fine to just
> fix the bugs for now.

;-).

> I noticed that there's another "generate" subcommand here that is
> entirely unused. Do we maybe want to also remove it while at it? The
> test suite passes with the below diff.

Great.

Thanks.