git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] remote: filter out invalid remote configurations

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 30, 2013, 16:58 UTC
Message-ID
<xmqqwqn3yv2n.fsf@gitster.dls.corp.google.com>
In-Reply-To
<1377866509.1714.0.camel@centaur.cmartin.tk>
Carlos Martín Nieto <cmn@elego.de> writes:
Show 21 quoted lines
> On Tue, 2013-08-27 at 07:50 -0700, Junio C Hamano wrote:
>> Carlos Martín Nieto <cmn@elego.de> writes:
>> 
>> > In remote's configuration callback, anything that looks like
>> > 'remote.<name>.*' creates a remote '<name>'. This remote may not end
>> > up having any configuration for a remote, but it's still in the list,
>> > so 'git remote' shows it, which means something like
>> >
>> >     [remote "bogus"]
>> >         hocus = pocus
>> >
>> > will show a remote 'bogus' in the listing, even though it won't work
>> > as a remote name for either git-fetch or git-push.
>> 
>> Isn't this something the user may want to be aware of, though?
>> Hiding these would rob a chance for such an entry to be noticed from
>> the user---is it a good change?
>
> If we want to help the user know that there's something a bit odd in
> their configuration, shouldn't we tell them instead of hoping they
> stumble upon it?

Yeah, I agree that "git remote" that tells the above "bogus" is fishy is better than just hides it.

Previous: Carlos Martín Nieto
Message 4 of 4 in “remote: filter out invalid remote configurations”
  1. remote: filter out invalid remote configurationsCarlos Martín Nieto, Aug 27, 2013
  2. Junio C HamanoAug 27, 2013
  3. Carlos Martín NietoAug 30, 2013
  4. Junio C HamanoAug 30, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.