Re: [PATCH] remote: filter out invalid remote configurations

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 27, 2013, 14:50 UTC
Message-ID: <xmqqr4dffarq.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1377608796-13732-1-git-send-email-cmn@elego.de>

Carlos Martín Nieto <cmn@elego.de> writes:

Show 10 quoted lines

> In remote's configuration callback, anything that looks like
> 'remote.<name>.*' creates a remote '<name>'. This remote may not end
> up having any configuration for a remote, but it's still in the list,
> so 'git remote' shows it, which means something like
>
>     [remote "bogus"]
>         hocus = pocus
>
> will show a remote 'bogus' in the listing, even though it won't work
> as a remote name for either git-fetch or git-push.

Isn't this something the user may want to be aware of, though? Hiding these would rob a chance for such an entry to be noticed from the user---is it a good change?

> Filter out the remotes that we created which have no urls in order to
> work around such configuration entries.