Re: [PATCH v5 2/9] test: add test_write_lines helper

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 24, 2014, 18:31 UTC
Message-ID: <xmqqwqeevatc.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20140424170826.GH15516@google.com>

Jonathan Nieder <jrnieder@gmail.com> writes:

Show 19 quoted lines

> Michael S. Tsirkin wrote:
>
>> --- a/t/test-lib-functions.sh
>> +++ b/t/test-lib-functions.sh
>> @@ -712,6 +712,11 @@ test_ln_s_add () {
>>  	fi
>>  }
>>  
>> +# This function writes out its parameters, one per line
>> +test_write_lines () {
>> +	printf "%s\n" "$@";
>> +}
>> +
>
> Thanks for fixing this.
>
> Nits:
>
>  * no need for the trailing semicolon

Good eyes. I was wondering if I wrote that (which I found very unlikely).

>  * it's probably worth documenting this in t/README as well so people
>    writing new test scripts know what it's about.

Sounds like a good idea.

Thanks.