Re: [PATCH v5 2/9] test: add test_write_lines helper
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Apr 24, 2014, 17:08 UTC
- Message-ID
- <20140424170826.GH15516@google.com>
- In-Reply-To
- <1398331809-11309-2-git-send-email-mst@redhat.com>
Michael S. Tsirkin wrote:
Show 11 quoted lines
> --- a/t/test-lib-functions.sh
> +++ b/t/test-lib-functions.sh
> @@ -712,6 +712,11 @@ test_ln_s_add () {
> fi
> }
>
> +# This function writes out its parameters, one per line
> +test_write_lines () {
> + printf "%s\n" "$@";
> +}
> +Thanks for fixing this.
Nits:
* no need for the trailing semicolon * it's probably worth documenting this in t/README as well so people writing new test scripts know what it's about.
Thanks, Jonathan