git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] progress: no progress in background

From
Junio C Hamano <gitster@pobox.com>
Date
May 19, 2015, 16:12 UTC
Message-ID
<xmqqwq048s2a.fsf@gitster.dls.corp.google.com>
In-Reply-To
<20150519051752.GA16173@peff.net>
Jeff King <peff@peff.net> writes:
Show 7 quoted lines
>> +static int is_foreground_fd(int fd)
>> +{
>> +	return getpgid(0) == tcgetpgrp(fd);
>> +}
>
> I've noticed that this patch causes a regression when we are
> transmitting progress over the sideband channel of the git protocol.

Yeah, thanks. The other day when an unrelated progress issues came, I realized that this patch has that breakage (and immediately forgot about it ;-).

> ... Whatever the reason, it probably makes sense to err on the
> side of printing the progress.
Yup.  Thanks.
Previous: Jeff King
Message 4 of 4 in “progress: no progress in background”
  1. progress: no progress in backgroundLuke Mewburn, Apr 15, 2015
  2. Jeff KingMay 19, 2015
  3. progress: treat "no terminal" as being in the foregroundJeff King, May 19, 2015
  4. Junio C HamanoMay 19, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.