From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 19 May 2015 16:12:29 GMT
Subject: Re: [PATCH] progress: no progress in background
Message-ID: <xmqqwq048s2a.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20150519051752.GA16173@peff.net>

Jeff King <peff@peff.net> writes:

>> +static int is_foreground_fd(int fd)
>> +{
>> +	return getpgid(0) == tcgetpgrp(fd);
>> +}
>
> I've noticed that this patch causes a regression when we are
> transmitting progress over the sideband channel of the git protocol.

Yeah, thanks.  The other day when an unrelated progress issues came,
I realized that this patch has that breakage (and immediately forgot
about it ;-).

> ... Whatever the reason, it probably makes sense to err on the
> side of printing the progress.

Yup.  Thanks.