git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 1/3] tree-walk: be more specific about corrupt tree errors

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 27, 2016, 16:55 UTC
Message-ID
<xmqqwphxp9iy.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<1474989806-5002-1-git-send-email-dturner@twosigma.com>
David Turner <dturner@twosigma.com> writes:
Show 18 quoted lines
> From: Jeff King <peff@peff.net>
>
> When the tree-walker runs into an error, it just calls
> die(), and the message is always "corrupt tree file".
> However, we are actually covering several cases here; let's
> give the user a hint about what happened.
>
> Let's also avoid using the word "corrupt", which makes it
> seem like the data bit-rotted on disk. Our sha1 check would
> already have found that. These errors are ones of data that
> is malformed in the first place.
>
> Signed-off-by: David Turner <dturner@twosigma.com>
> Signed-off-by: Jeff King <peff@peff.net>
> ---
>  t/t1007-hash-object.sh | 21 +++++++++++++++++++--
>  tree-walk.c            | 12 +++++++-----
>  2 files changed, 26 insertions(+), 7 deletions(-)

Nice that we now prepare the test data ourselves without shipping as part of the source.

Previous: Junio C HamanoNext: Jeff King
Message 6 of 7 in “tree-walk: be more specific about corrupt tree errors”
  1. 1/3 tree-walk: be more specific about corrupt tree errorsDavid Turner, Sep 27, 2016
  2. 2/3 fsck: handle bad trees like other errorsDavid Turner, Sep 27, 2016
  3. Jeff KingSep 27, 2016
  4. 3/3 add David Turner's Two Sigma addressDavid Turner, Sep 27, 2016
  5. Junio C HamanoSep 27, 2016
  6. Junio C HamanoSep 27, 2016
  7. Jeff KingSep 27, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.