From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 27 Sep 2016 16:55:33 GMT
Subject: Re: [PATCH v3 1/3] tree-walk: be more specific about corrupt tree errors
Message-ID: <xmqqwphxp9iy.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1474989806-5002-1-git-send-email-dturner@twosigma.com>

David Turner <dturner@twosigma.com> writes:

> From: Jeff King <peff@peff.net>
>
> When the tree-walker runs into an error, it just calls
> die(), and the message is always "corrupt tree file".
> However, we are actually covering several cases here; let's
> give the user a hint about what happened.
>
> Let's also avoid using the word "corrupt", which makes it
> seem like the data bit-rotted on disk. Our sha1 check would
> already have found that. These errors are ones of data that
> is malformed in the first place.
>
> Signed-off-by: David Turner <dturner@twosigma.com>
> Signed-off-by: Jeff King <peff@peff.net>
> ---
>  t/t1007-hash-object.sh | 21 +++++++++++++++++++--
>  tree-walk.c            | 12 +++++++-----
>  2 files changed, 26 insertions(+), 7 deletions(-)

Nice that we now prepare the test data ourselves without shipping as
part of the source.