git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gc --auto: release pack files before auto packing

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 9, 2018, 21:10 UTC
Message-ID
<xmqqwou4azev.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<CACsJy8C=Xs1QY_cMu+H4DR9XovBd5bO-ZC=ie-1x9yZepgUMdA@mail.gmail.com>
Duy Nguyen <pclouds@gmail.com> writes:
Show 11 quoted lines
> On Sun, Jul 8, 2018 at 1:16 AM Kim Gybels <kgybels@infogroep.be> wrote:
>> Should I post a v3 that goes back to the original fix, but uses
>> test_i18ngrep instead of grep?
>
> Yes please. In my comment I did write we didn't need the repo anymore
> (or something along that line) which turns out to be wrong.
>
>> In addition to not breaking any tests, close_all_packs is already used
>> in a similar way in am and fetch just before running "gc --auto".
>>
>> -Kim
Sound good.

I recall that "clear repo should treat the_repository special" was discussed when we saw the patch that became 74373b5f ("repository: fix free problem with repo_clear(the_repository)", 2018-05-10), instead of treating only the index portion specially. Perhaps it was a more correct approach after all?

Previous: Duy NguyenNext: Duy Nguyen
Message 7 of 11 in “gc --auto: release pack files before auto packing”
  1. gc --auto: release pack files before auto packingKim Gybels, Jun 30, 2018
  2. Duy NguyenJun 30, 2018
  3. Junio C HamanoJul 6, 2018
  4. SZEDER GáborJul 7, 2018
  5. Kim GybelsJul 7, 2018
  6. Duy NguyenJul 9, 2018
  7. Junio C HamanoJul 9, 2018
  8. Duy NguyenJul 11, 2018
  9. gc --auto: clear repository before auto packingKim Gybels, Jul 4, 2018
  10. SZEDER GáborJul 7, 2018
  11. gc --auto: release pack files before auto packingKim Gybels, Jul 9, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.