Re: [PATCH v2] gc --auto: clear repository before auto packing

From: SZEDER Gábor <szeder.dev@gmail.com>
Date: Jul 7, 2018, 09:57 UTC
Message-ID: <CAM0VKjkCf+V1ZPGfghOcE73TAshd58V1QJz4af57jAjtktTu-A@mail.gmail.com>
In-Reply-To: <20180704201600.9908-1-kgybels@infogroep.be>

On Wed, Jul 4, 2018 at 10:16 PM Kim Gybels <kgybels@infogroep.be> wrote:

Show 15 quoted lines

> diff --git a/t/t5510-fetch.sh b/t/t5510-fetch.sh
> index e402aee6a2..ef599c11cd 100755
> --- a/t/t5510-fetch.sh
> +++ b/t/t5510-fetch.sh
> @@ -828,10 +828,12 @@ test_expect_success 'fetching with auto-gc does not lock up' '
>         test_commit test2 &&
>         (
>                 cd auto-gc &&
> +               git config fetch.unpackLimit 1 &&
>                 git config gc.autoPackLimit 1 &&
>                 git config gc.autoDetach false &&
>                 GIT_ASK_YESNO="$D/askyesno" git fetch >fetch.out 2>&1 &&
> -               ! grep "Should I try again" fetch.out
> +               test_i18ngrep "Auto packing the repository" fetch.out &&
> +               test_i18ngrep ! "Should I try again" fetch.out

The messages containing "Auto packing the repository" are indeed translated, thus they have to be checked with 'test_i18ngrep', good.

However, none of the "Should I try again" messages are translated, so checking them with bare 'grep' is fine and it shouldn't be changed.

Show 6 quoted lines

>         )
>  '
>
> --
> 2.18.0.windows.1
>