Re: What's cooking in git.git (Dec 2018, #01; Sun, 9)

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 11, 2018, 01:43 UTC
Message-ID: <xmqqwoogn8ha.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20181210185321.GB37614@google.com>

Josh Steadmon <steadmon@google.com> writes:

Show 14 quoted lines

> On 2018.12.09 17:42, Junio C Hamano wrote:
>> * js/protocol-advertise-multi (2018-11-17) 1 commit
>>  - protocol: advertise multiple supported versions
>> 
>>  The transport layer has been updated so that the protocol version
>>  used can be negotiated between the parties, by the initiator
>>  listing the protocol versions it is willing to talk, and the other
>>  side choosing from one of them.
>> 
>>  How's the doneness of this one?
>
> I'm not sure if you're asking me specifically or the list in general,
> but I haven't heard any complaints about this, and there are no
> outstanding requests on the review thread.

It is both but more of the latter ;-) "I haven't seen any problem reported, and all review comments have been addressed" by you is also a welcome feedback.

Show 16 quoted lines

>> * js/smart-http-detect-remote-error (2018-11-17) 3 commits
>>   (merged to 'next' on 2018-11-18 at 5c6edfcb85)
>>  + remote-curl: die on server-side errors
>>  + remote-curl: tighten "version 2" check for smart-http
>>  + remote-curl: refactor smart-http discovery
>> 
>>  Some errors from the other side coming over smart HTTP transport
>>  were not noticed, which has been corrected.
>> 
>>  Will cook in 'next'.
>
> Masaya had a series that addresses this as well:
> https://public-inbox.org/git/20181127045301.103807-1-masayasuzuki@google.com/
>
> To combine these, we'd want to drop the diff to remote-curl.c in the
> final patch of this series.

OK, I'll kick the topic out of 'next' when reopening the tree for the next cycle. Could you work with him to feed me the result of combined effort to replace these three patches? Thanks.