pw/add-p-select, was Re: What's cooking in git.git (Dec 2018, #01; Sun, 9)

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Dec 9, 2018, 20:31 UTC
Message-ID: <nycvar.QRO.7.76.6.1812092101570.43@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqq8t0z3xcc.fsf@gitster-ct.c.googlers.com>

Hi Junio,

On Sun, 9 Dec 2018, Junio C Hamano wrote:

Show 12 quoted lines

> * pw/add-p-select (2018-07-26) 4 commits
>  - add -p: optimize line selection for short hunks
>  - add -p: allow line selection to be inverted
>  - add -p: select modified lines correctly
>  - add -p: select individual hunk lines
> 
>  "git add -p" interactive interface learned to let users choose
>  individual added/removed lines to be used in the operation, instead
>  of accepting or rejecting a whole hunk.
> 
>  Will discard.
>  No further feedbacks on the topic for quite some time.

That is not quite true. I did comment that this feature (which I take as being inspired by Git GUI's "Stage Selected Line"), and thought that it would be useful.

I could imagine, however, that it would make sense for `git add -p` to imitate that feature more closely: by allowing to stage a single line and then presenting the current hunk (re-computed) again.

Ciao, Dscho