Re: [PATCH v3] diff-lib.c: handle empty deleted ita files

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 19, 2019, 20:15 UTC
Message-ID: <xmqqwof8x66a.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <CAK_rgsH0Yb=CAsCgD20xx==RaDzchtEua=q6K=7R-cfURFGHuQ@mail.gmail.com>

Varun Naik <vcnaik94@gmail.com> writes:

> This function is probably not the place where we want to make changes.
> It would be better to change diff-lib.c:show_modified() and
> diff.c:diff_change() to consider the intent-to-add bit when performing a
> diff.

I do agree that diff-lib.c::show_modified(), which is about "git diff-cache" (and hence "git diff <tree-ish>", i.e. comparison between a tree-ish and the index), is the right layer for this change.

I am not offhand sure about the diff.c::diff_change(), though, and cannot say much without first thinking about it a bit more.

Thanks.