git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] submodule: port subcommand 'set-url' from shell to C

From
Junio C Hamano <gitster@pobox.com>
Date
May 1, 2020, 18:54 UTC
Message-ID
<xmqqwo5vlc3i.fsf@gitster.c.googlers.com>
In-Reply-To
<20200501100109.GA55820@generichostname>
Denton Liu <liu.denton@gmail.com> writes:
Show 20 quoted lines
> On Fri, May 01, 2020 at 01:02:32PM +0530, Shourya Shukla wrote:
>> This aims to convert submodule subcommand 'set-url' to a builtin.
>> 'set-url' is ported to 'submodule--helper.c' and the latter is called
>> via 'git-submodule.sh'.
>
> Commit messages should be written in imperative mood. This could be
> rewritten as
>
> 	Convert submodule subcommand 'set-url' to a builtin. Port
> 	'set-url' to 'submodule--helper.c' and call the latter via
> 	'git-submodule.sh'.
> ...
>>  		esac
>> -		shift
>
> Hmmm, I don't understand why the above hunk and this line are necessary.
>
> ...
>
> This looks good, though :)

Thanks for giving a pretty good review. I think we covered many issues pretty much the same way.

Previous: Denton LiuNext: Junio C Hamano
Message 3 of 4 in “submodule: port subcommand 'set-url' from shell to C”
  1. submodule: port subcommand 'set-url' from shell to CShourya Shukla, May 1, 2020
  2. Denton LiuMay 1, 2020
  3. Junio C HamanoMay 1, 2020
  4. Junio C HamanoMay 1, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.