From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 01 May 2020 18:54:57 GMT
Subject: Re: [PATCH v2] submodule: port subcommand 'set-url' from shell to C
Message-ID: <xmqqwo5vlc3i.fsf@gitster.c.googlers.com>
In-Reply-To: <20200501100109.GA55820@generichostname>

Denton Liu <liu.denton@gmail.com> writes:

> On Fri, May 01, 2020 at 01:02:32PM +0530, Shourya Shukla wrote:
>> This aims to convert submodule subcommand 'set-url' to a builtin.
>> 'set-url' is ported to 'submodule--helper.c' and the latter is called
>> via 'git-submodule.sh'.
>
> Commit messages should be written in imperative mood. This could be
> rewritten as
>
> 	Convert submodule subcommand 'set-url' to a builtin. Port
> 	'set-url' to 'submodule--helper.c' and call the latter via
> 	'git-submodule.sh'.
> ...
>>  		esac
>> -		shift
>
> Hmmm, I don't understand why the above hunk and this line are necessary.
>
> ...
>
> This looks good, though :)

Thanks for giving a pretty good review.  I think we covered many
issues pretty much the same way.