Re: [PATCH] submodule--helper.c: add only-active to foreach

From: Junio C Hamano <gitster@pobox.com>
Date: May 13, 2020, 15:35 UTC
Message-ID: <xmqqwo5fvoe1.fsf@gitster.c.googlers.com>
In-Reply-To: <cf25c55e-e0c8-6374-3adf-84f4314869e9@gmail.com>

Guillaume Galeazzi <guillaume.galeazzi@gmail.com> writes:

Show 15 quoted lines

>> 	git submodule foreach --trait=is-active ...
>> 	git submodule foreach --trait=!is-active ...
>> 	git submodule foreach --trait=is-populated ...
>>
>> to allow iterating only on submodules with/without given trait (I am
>> not suggesting the actual option name, but merely making sure that
>> 'is-active' is not anything special but one of the possibilities
>> that can be used to limit the iteration using the same mechanism).
>
> The idea that other candidate are possible seem good. But then users
> will need combination like is-active && !is-populated. ...
> ... this would allow combination with the is active filter and the
> previous example would be
>
>         git submodule--helper --is-active --is-populated=false <cmd>

There is no difference between that and

	git submodule--helper --trait=is-active --trait=is-populated

so I fail to see what new you are proposing, sorry.