git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: racy test failure in tb/upload-pack-filters

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 5, 2020, 16:28 UTC
Message-ID
<xmqqwo2dnjk5.fsf@gitster.c.googlers.com>
In-Reply-To
<20200805092658.GA1803042@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
> By the way, grepping for "remote error:" shows that when we get an error
> over sideband 3 we produce the same message but _don't_ translate it.
> That seems inconsistent.
IOW
    die(_("remote error: %s"), buf + 1);
in sideband.c?  I think it makes sense.

IIRC, the current thinking is to let the remote side localize their message before sending them over the wire and we'll worry about how we let the receiving end tell what l10n it wants later. So "remote error:" prefix may have to be translated on receiving end and the remainder of the line, which is already localized, can just be interpolated.

Previous: Taylor BlauNext: Jeff King
Message 5 of 11 in “racy test failure in tb/upload-pack-filters”
  1. Jeff KingAug 5, 2020
  2. SZEDER GáborAug 5, 2020
  3. Jeff KingAug 5, 2020
  4. Taylor BlauAug 5, 2020
  5. Junio C HamanoAug 5, 2020
  6. sideband: mark "remote error:" prefix for translationJeff King, Aug 7, 2020
  7. Junio C HamanoAug 7, 2020
  8. Martin ÅgrenAug 5, 2020
  9. Jeff KingAug 5, 2020
  10. Martin ÅgrenAug 5, 2020
  11. Taylor BlauAug 5, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.