Re: racy test failure in tb/upload-pack-filters

From: Martin Ågren <martin.agren@gmail.com>
Date: Aug 5, 2020, 09:27 UTC
Message-ID: <CAN0heSqsHGL2Pb37d2dWL+RCWac4z8mjpM-v6v6zsxH_8cWQjQ@mail.gmail.com>
In-Reply-To: <20200805084240.GA1802257@coredump.intra.peff.net>

On Wed, 5 Aug 2020 at 10:45, Jeff King <peff@peff.net> wrote:

Show 7 quoted lines

>
>   $ GIT_TEST_GETTEXT_POISON=1 ./t5616-partial-clone.sh --stress
>   FAIL 19.1
>   FAIL 15.1
>   OK   26.1
>   OK   16.1
>   ...

[...]

Show 13 quoted lines

> OK, so what's in that file?
>
>   $ cd trash\ directory.t5616-partial-clone.stress-failed/
>   $ cat err
>   # GETTEXT POISON #fatal: # GETTEXT POISON #
>   fatal: filter 'blob:none' not supported
>
> What, it's there!? Is it somehow confusing grep?
>
>   $ grep "filter 'blob:none' not supported" err
>   fatal: filter 'blob:none' not supported
>   $ echo $?
>   0

Nice. :-)

> -- >8 --
> Subject: t5616: use test_i18ngrep for upload-pack errors

[...snipping lots of good stuff...]

> In theory we'd see both copies of the message in the second case. But
> now always! As soon as the client sees ERR, it exits and we run grep.

s/now/not/

Very nicely explained, as always.

> -       grep "filter '\''blob:none'\'' not supported" err
> +       test_i18ngrep "filter '\''blob:none'\'' not supported" err

Right, this is the one from the intro and the commit message.

> -       grep "tree filter allows max depth 0, but got 1" err
> +       test_i18ngrep "tree filter allows max depth 0, but got 1" err

This one isn't translated, so this hunk could be dropped. Or maybe you wanted to knowingly cast a slightly wider net? (And this does fit the subject of your patch.)

Martin