git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 6/6] git-sh-setup: remove "sane_grep", it's not needed anymore

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 21, 2021, 23:17 UTC
Message-ID
<xmqqwnm6ge7w.fsf@gitster.g>
In-Reply-To
<patch-6.6-556fa96dde7-20211021T195538Z-avarab@gmail.com>
Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:
> 2. The SANE_TEXT_GREP added in 71b401032b9 (sane_grep: pass "-a" if
>    grep accepts it, 2016-03-08) isn't needed either, none of these grep
>    uses deal with binary data.

For all other users, I think the above applies well, but the one in filter-branch deals with end-user contents, so we cannot say "contents of the tag cannot be binary".

Not that I care about filter-branch too deeply ;-)
Previous: Ævar Arnfjörð BjarmasonNext: Johannes Schindelin
Message 10 of 15 in “Makefile: be less eager to re-build, *.sh code cleanups”
  1. 0/6 Makefile: be less eager to re-build, *.sh code cleanupsÆvar Arnfjörð Bjarmason, Oct 21, 2021
  2. 1/6 Makefile: move git-SCRIPT-DEFINES adjacent to $(SCRIPT_DEFINES)Ævar Arnfjörð Bjarmason, Oct 21, 2021
  3. 2/6 Makefile: remove $(GIT_VERSION) from $(SCRIPT_DEFINES)Ævar Arnfjörð Bjarmason, Oct 21, 2021
  4. Jeff KingOct 25, 2021
  5. 3/6 Makefile: remove $(NO_CURL) from $(SCRIPT_DEFINES)Ævar Arnfjörð Bjarmason, Oct 21, 2021
  6. 4/6 git-instaweb: unconditionally assume that gitweb is mod_perl capableÆvar Arnfjörð Bjarmason, Oct 21, 2021
  7. 5/6 git-sh-setup: remove unused sane_egrep() functionÆvar Arnfjörð Bjarmason, Oct 21, 2021
  8. Junio C HamanoOct 22, 2021
  9. 6/6 git-sh-setup: remove "sane_grep", it's not needed anymoreÆvar Arnfjörð Bjarmason, Oct 21, 2021
  10. Junio C HamanoOct 21, 2021
  11. Johannes SchindelinOct 22, 2021
  12. Junio C HamanoOct 24, 2021
  13. Johannes SchindelinOct 25, 2021
  14. Junio C HamanoOct 25, 2021
  15. Jeff KingOct 25, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.