git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/6] Makefile: remove $(NO_CURL) from $(SCRIPT_DEFINES)

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Oct 21, 2021, 19:57 UTC
Message-ID
<patch-3.6-04c45e191a9-20211021T195538Z-avarab@gmail.com>
In-Reply-To
<cover-0.6-00000000000-20211021T195538Z-avarab@gmail.com>

Stop including $(NO_CURL) in $(SCRIPT_DEFINES). The "@NO_CURL@" replacement added in 6c5c62f3401 (Print an error if cloning a http repo and NO_CURL is set, 2006-02-15) has not been referenced by anything in-tree since 49eb8d39c78 (Remove contrib/examples/*, 2018-03-25).

That commit removed the reference from contrib/examples/*, but this @@NO_CURL@@ hasn't been used since git-pull.sh was the primary entry point for "git pull".

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 Makefile | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index fdce392929b..50eba522f4e 100644
--- a/Makefile
+++ b/Makefile
@@ -2253,7 +2253,7 @@ hook-list.h: generate-hooklist.sh Documentation/githooks.txt
 	$(QUIET_GEN)$(SHELL_PATH) ./generate-hooklist.sh >$@
 
 SCRIPT_DEFINES = $(SHELL_PATH_SQ):$(DIFF_SQ):\
-	$(localedir_SQ):$(NO_CURL):$(USE_GETTEXT_SCHEME):$(SANE_TOOL_PATH_SQ):\
+	$(localedir_SQ):$(USE_GETTEXT_SCHEME):$(SANE_TOOL_PATH_SQ):\
 	$(gitwebdir_SQ):$(PERL_PATH_SQ):$(SANE_TEXT_GREP):$(PAGER_ENV):\
 	$(perllibdir_SQ)
 GIT-SCRIPT-DEFINES: FORCE
@@ -2268,7 +2268,6 @@ sed -e '1s|#!.*/sh|#!$(SHELL_PATH_SQ)|' \
     -e 's|@SHELL_PATH@|$(SHELL_PATH_SQ)|' \
     -e 's|@@DIFF@@|$(DIFF_SQ)|' \
     -e 's|@@LOCALEDIR@@|$(localedir_SQ)|g' \
-    -e 's/@@NO_CURL@@/$(NO_CURL)/g' \
     -e 's/@@USE_GETTEXT_SCHEME@@/$(USE_GETTEXT_SCHEME)/g' \
     -e $(BROKEN_PATH_FIX) \
     -e 's|@@GITWEBDIR@@|$(gitwebdir_SQ)|g' \
-- 
2.33.1.1494.g88b39a443e1
Previous: Jeff KingNext: Ævar Arnfjörð Bjarmason
Message 5 of 15 in “Makefile: be less eager to re-build, *.sh code cleanups”
  1. 0/6 Makefile: be less eager to re-build, *.sh code cleanupsÆvar Arnfjörð Bjarmason, Oct 21, 2021
  2. 1/6 Makefile: move git-SCRIPT-DEFINES adjacent to $(SCRIPT_DEFINES)Ævar Arnfjörð Bjarmason, Oct 21, 2021
  3. 2/6 Makefile: remove $(GIT_VERSION) from $(SCRIPT_DEFINES)Ævar Arnfjörð Bjarmason, Oct 21, 2021
  4. Jeff KingOct 25, 2021
  5. 3/6 Makefile: remove $(NO_CURL) from $(SCRIPT_DEFINES)Ævar Arnfjörð Bjarmason, Oct 21, 2021
  6. 4/6 git-instaweb: unconditionally assume that gitweb is mod_perl capableÆvar Arnfjörð Bjarmason, Oct 21, 2021
  7. 5/6 git-sh-setup: remove unused sane_egrep() functionÆvar Arnfjörð Bjarmason, Oct 21, 2021
  8. Junio C HamanoOct 22, 2021
  9. 6/6 git-sh-setup: remove "sane_grep", it's not needed anymoreÆvar Arnfjörð Bjarmason, Oct 21, 2021
  10. Junio C HamanoOct 21, 2021
  11. Johannes SchindelinOct 22, 2021
  12. Junio C HamanoOct 24, 2021
  13. Johannes SchindelinOct 25, 2021
  14. Junio C HamanoOct 25, 2021
  15. Jeff KingOct 25, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.