Re: [PATCH] editor: only save (and restore) the terminal if using a tty
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 24, 2021, 19:34 UTC
- Message-ID
- <xmqqwnkx1h5y.fsf@gitster.g>
- In-Reply-To
- <nycvar.QRO.7.76.6.2111241428190.63@tvgsbejvaqbjf.bet>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> Maybe a better approach would be to hide the `save_term()` dance behind a > new config option, and then have it turned on automatically if the > `editor` _happens_ to be `vi` or `vim`.
Why 'vi' and 'vim' are so special? Is this an attempt to paper over a bug in 'vim' on the caller side?
Show 5 quoted lines
> > That would help the problem reported in the Windows Terminal project. > > Ciao, > Dscho