Re: [PATCH] editor: only save (and restore) the terminal if using a tty
- From
Carlo Arenas <carenas@gmail.com>
- Date
- Nov 24, 2021, 18:25 UTC
- Message-ID
- <CAPUEspi2PRs+yMUiAmvJK+z=F=kcguHpOL2inAV208yaq2n2Ww@mail.gmail.com>
- In-Reply-To
- <nycvar.QRO.7.76.6.2111241428190.63@tvgsbejvaqbjf.bet>
On Wed, Nov 24, 2021 at 5:29 AM Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> > Maybe a better approach would be to hide the `save_term()` dance behind a > new config option, and then have it turned on automatically if the > `editor` _happens_ to be `vi` or `vim`.
that but without turning it on automatically was what I was preparing[1] (2 commits apply on top of master after the revert) as an alternative to present for the 2.35 dev cycle.
I agree though that "turning it on automatically" might be worth adding for the git for windows fork to minimize impact, but even without it, I would hope the people affected wouldn't mind setting the config themselves or could even be done for them at install time by the installer.
Carlo
[1] https://github.com/carenas/git/commits/seen