git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 00/21] git-p4: Various code tidy-ups

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 13, 2022, 23:03 UTC
Message-ID
<xmqqwnj3fdb8.fsf@gitster.g>
In-Reply-To
<20220113134728.23192-1-jholdsworth@nvidia.com>

Doesn't this conflict with your own topics that are already cooking in 'next'? For example, I am seeing many conflicts like this one.

    def rebase(self):
        if os.system("git update-index --refresh") != 0:
<<<<<<< HEAD
            die("Some files in your working directory are modified and different than what is in your index. You can use git update-index <filename> to bring the index up to date or stash away all your changes with git stash.");
        if len(read_pipe(["git", "diff-index", "HEAD", "--"])) > 0:
            die("You have uncommitted changes. Please commit them before rebasing or stash them away with git stash.");
||||||| 1ffcbaa1a5
            die("Some files in your working directory are modified and different than what is in your index. You can use git update-index <filename> to bring the index up to date or stash away all your changes with git stash.");
        if len(read_pipe("git diff-index HEAD --")) > 0:
            die("You have uncommitted changes. Please commit them before rebasing or stash them away with git stash.");
=======
            die("Some files in your working directory are modified and different than what is in your index. You can use git update-index <filename> to bring the index up to date or stash away all your changes with git stash.")
        if len(read_pipe("git diff-index HEAD --")) > 0:
            die("You have uncommitted changes. Please commit them before rebasing or stash them away with git stash.")
>>>>>>> jh/p4-code-tidy-ups

As new things in 'next' that are not in 'master' are not moving until the final release of this cycle, perhaps this needs to wait until much later in the month (see tinyurl.com/gitCal).

Thanks.
Previous: Joel HoldsworthNext: Joel Holdsworth
Message 23 of 24 in “git-p4: Various code tidy-ups”
  1. 00/21 git-p4: Various code tidy-upsJoel Holdsworth, Jan 13, 2022
  2. 01/21 git-p4: add blank lines between functions and class definitionsJoel Holdsworth, Jan 13, 2022
  3. 02/21 git-p4: remove unneeded semicolons from statementsJoel Holdsworth, Jan 13, 2022
  4. 03/21 git-p4: indent with 4-spacesJoel Holdsworth, Jan 13, 2022
  5. 04/21 git-p4: improve consistency of docstring formattingJoel Holdsworth, Jan 13, 2022
  6. 05/21 git-p4: convert descriptive class and function comments into docstringsJoel Holdsworth, Jan 13, 2022
  7. 06/21 git-p4: remove commented codeJoel Holdsworth, Jan 13, 2022
  8. 07/21 git-p4: sort and de-duplcate pylint disable listJoel Holdsworth, Jan 13, 2022
  9. 10/21 git-p4: removed brackets when assigning multiple return valuesJoel Holdsworth, Jan 13, 2022
  10. 08/21 git-p4: remove padding from lists, tuples and function argumentsJoel Holdsworth, Jan 13, 2022
  11. 11/21 git-p4: place a single space after every commaJoel Holdsworth, Jan 13, 2022
  12. 09/21 git-p4: remove spaces around default argumentsJoel Holdsworth, Jan 13, 2022
  13. 12/21 git-p4: remove extraneous spaces before function argumentsJoel Holdsworth, Jan 13, 2022
  14. 13/21 git-p4: remove redundant backslash-continuations inside bracketsJoel Holdsworth, Jan 13, 2022
  15. 14/21 git-p4: remove spaces between dictionary keys and colonsJoel Holdsworth, Jan 13, 2022
  16. 15/21 git-p4: ensure every comment has a single #Joel Holdsworth, Jan 13, 2022
  17. 18/21 git-p4: compare to singletons with "is" and "is not"Joel Holdsworth, Jan 13, 2022
  18. 16/21 git-p4: ensure there is a single space around all operatorsJoel Holdsworth, Jan 13, 2022
  19. 21/21 git-p4: seperate multiple statements onto seperate linesJoel Holdsworth, Jan 13, 2022
  20. 17/21 git-p4: normalize indentation of lines in conditionalsJoel Holdsworth, Jan 13, 2022
  21. 19/21 git-p4: only seperate code blocks by a single empty lineJoel Holdsworth, Jan 13, 2022
  22. 20/21 git-p4: move inline comments to line aboveJoel Holdsworth, Jan 13, 2022
  23. Junio C HamanoJan 13, 2022
  24. Joel HoldsworthJan 14, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.