git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 06/21] git-p4: remove commented code

From
Joel Holdsworth <jholdsworth@nvidia.com>
Date
Jan 13, 2022, 13:47 UTC
Message-ID
<20220113134728.23192-7-jholdsworth@nvidia.com>
In-Reply-To
<20220113134728.23192-1-jholdsworth@nvidia.com>

Previously, the script contained commented code including Python 2 print statements. Presumably, these were used as a developer aid at some point in history. However, the commented code is generally undesirable, and this commented code serves no useful purpose. Therefore this patch removes it.

Signed-off-by: Joel Holdsworth <jholdsworth@nvidia.com>
---
Corrected typos in the commit message at Eric Sunshine's prompting.
 git-p4.py | 7 -------
 1 file changed, 7 deletions(-)
diff --git a/git-p4.py b/git-p4.py
index 186ac36300..b598144fad 100755
--- a/git-p4.py
+++ b/git-p4.py
@@ -3657,23 +3657,18 @@ def importNewBranch(self, branch, maxChange):
         self.gitStream.flush()
         branchPrefix = self.depotPaths[0] + branch + "/"
         range = "@1,%s" % maxChange
-        #print "prefix" + branchPrefix
         changes = p4ChangesForPaths([branchPrefix], range, self.changes_block_size)
         if len(changes) <= 0:
             return False
         firstChange = changes[0]
-        #print "first change in branch: %s" % firstChange
         sourceBranch = self.knownBranches[branch]
         sourceDepotPath = self.depotPaths[0] + sourceBranch
         sourceRef = self.gitRefForBranch(sourceBranch)
-        #print "source " + sourceBranch
 
         branchParentChange = int(p4Cmd(["changes", "-m", "1", "%s...@1,%s" % (sourceDepotPath, firstChange)])["change"])
-        #print "branch parent: %s" % branchParentChange
         gitParent = self.gitCommitByP4Change(sourceRef, branchParentChange)
         if len(gitParent) > 0:
             self.initialParents[self.gitRefForBranch(branch)] = gitParent
-            #print "parent git commit: %s" % gitParent
 
         self.importChanges(changes)
         return True
@@ -3816,8 +3811,6 @@ def importHeadRevision(self, revision):
                 newestRevision = change
 
             if info["action"] in self.delete_actions:
-                # don't increase the file cnt, otherwise details["depotFile123"] will have gaps!
-                #fileCnt = fileCnt + 1
                 continue
 
             for prop in ["depotFile", "rev", "action", "type" ]:
-- 
2.34.1
Previous: Joel HoldsworthNext: Joel Holdsworth
Message 7 of 24 in “git-p4: Various code tidy-ups”
  1. 00/21 git-p4: Various code tidy-upsJoel Holdsworth, Jan 13, 2022
  2. 01/21 git-p4: add blank lines between functions and class definitionsJoel Holdsworth, Jan 13, 2022
  3. 02/21 git-p4: remove unneeded semicolons from statementsJoel Holdsworth, Jan 13, 2022
  4. 03/21 git-p4: indent with 4-spacesJoel Holdsworth, Jan 13, 2022
  5. 04/21 git-p4: improve consistency of docstring formattingJoel Holdsworth, Jan 13, 2022
  6. 05/21 git-p4: convert descriptive class and function comments into docstringsJoel Holdsworth, Jan 13, 2022
  7. 06/21 git-p4: remove commented codeJoel Holdsworth, Jan 13, 2022
  8. 07/21 git-p4: sort and de-duplcate pylint disable listJoel Holdsworth, Jan 13, 2022
  9. 10/21 git-p4: removed brackets when assigning multiple return valuesJoel Holdsworth, Jan 13, 2022
  10. 08/21 git-p4: remove padding from lists, tuples and function argumentsJoel Holdsworth, Jan 13, 2022
  11. 11/21 git-p4: place a single space after every commaJoel Holdsworth, Jan 13, 2022
  12. 09/21 git-p4: remove spaces around default argumentsJoel Holdsworth, Jan 13, 2022
  13. 12/21 git-p4: remove extraneous spaces before function argumentsJoel Holdsworth, Jan 13, 2022
  14. 13/21 git-p4: remove redundant backslash-continuations inside bracketsJoel Holdsworth, Jan 13, 2022
  15. 14/21 git-p4: remove spaces between dictionary keys and colonsJoel Holdsworth, Jan 13, 2022
  16. 15/21 git-p4: ensure every comment has a single #Joel Holdsworth, Jan 13, 2022
  17. 18/21 git-p4: compare to singletons with "is" and "is not"Joel Holdsworth, Jan 13, 2022
  18. 16/21 git-p4: ensure there is a single space around all operatorsJoel Holdsworth, Jan 13, 2022
  19. 21/21 git-p4: seperate multiple statements onto seperate linesJoel Holdsworth, Jan 13, 2022
  20. 17/21 git-p4: normalize indentation of lines in conditionalsJoel Holdsworth, Jan 13, 2022
  21. 19/21 git-p4: only seperate code blocks by a single empty lineJoel Holdsworth, Jan 13, 2022
  22. 20/21 git-p4: move inline comments to line aboveJoel Holdsworth, Jan 13, 2022
  23. Junio C HamanoJan 13, 2022
  24. Joel HoldsworthJan 14, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.