Re: [PATCH v4 4/6] tests: don't lose exit status with "test <op> $(git ...)"
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 26, 2022, 01:14 UTC
- Message-ID
- <xmqqwn6fm0e1.fsf@gitster.g>
- In-Reply-To
- <patch-v4-4.6-da66e5bf1c1-20221219T101240Z-avarab@gmail.com>
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
Show 12 quoted lines
> As with the preceding commit, rewrite tests that ran "git" inside > command substitution and lost the exit status of "git" so that we > notice the failing "git". This time around we're converting cases that > didn't involve a containing sub-shell around the command substitution. > > In the case of "t0060-path-utils.sh" and > "t2005-checkout-index-symlinks.sh" convert the relevant code to using > the modern style of indentation and newline wrapping while having to > change it. > > Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> > ---
Unlike the previous one, this looks sharply focused to deal with having $(git ...) as one of the arguments to "test". Looking good.