Re: [PATCH v3 8/8] tests: don't lose mist "git" exit codes
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 5, 2022, 00:45 UTC
- Message-ID
- <xmqq1qpeu18r.fsf@gitster.g>
- In-Reply-To
- <CAPig+cTh487GoAnw9CD7i2GmKzAtoG=1hwGdxXHQYoK6Vi=Arw@mail.gmail.com>
Eric Sunshine <sunshine@sunshineco.com> writes:
> On Fri, Dec 2, 2022 at 6:53 AM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote: >> tests: don't lose mist "git" exit codes > > "mist"?
s/t/c/ I thought.
In any case, it seems like 5,6,7,8/8 all are about using $(cmd) as an argument to another command (as opposed to placing it on the right side of a variable assignment) that loses the exit status of running $(cmd), and it is a bit confusing which piece should go into which one of these four. It might make more sense to reorganize these four steps along the file boundary.