Re: [PATCH] t4002: fix test #63 (missing whitespace)

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 25, 2023, 16:49 UTC
Message-ID: <xmqqwmyolywy.fsf@gitster.g>
In-Reply-To: <CAPig+cS8=iJD4fwvSacvWTK0WUH_DyjkQuMVP00aV+e4Q4TL3g@mail.gmail.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

Show 16 quoted lines

> Thanks for finding this problem and submitting a fix. You're the
> second person to do so[1].
>
> [1]: https://lore.kernel.org/git/pull.1545.git.git.1689341410476.gitgitgadget@gmail.com/
>
>> diff --git a/t/t4002-diff-basic.sh b/t/t4002-diff-basic.sh
>> @@ -401,9 +401,10 @@ test_expect_success 'diff-tree B A == diff-tree -R A B' '
>>  test_expect_success 'diff-tree -r B A == diff-tree -r -R A B' '
>>         git diff-tree -r $tree_B $tree_A >.test-a &&
>>         git diff-tree -r -R $tree_A $tree_B >.test-b &&
>> -       cmp -s .test-a .test-b'
>> +       cmp -s .test-a .test-b
>> +'
>
> This minor style fixup could be resubmitted as a standalone patch,
> though it might be too minor to worry about.

Thanks for a quick review and encouraging words. I do not mind a patch with only the above hunk but of course the title and the log message would have to be updated ;-).