Re: [PATCH] t4002: fix test #63 (missing whitespace)

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jul 25, 2023, 07:10 UTC
Message-ID: <CAPig+cS8=iJD4fwvSacvWTK0WUH_DyjkQuMVP00aV+e4Q4TL3g@mail.gmail.com>
In-Reply-To: <20230725063516.27242-1-aherrmann@suse.de>

On Tue, Jul 25, 2023 at 2:48 AM Andreas Herrmann <aherrmann@suse.de> wrote:

Show 6 quoted lines

> Add missing whitespace between 'test_expect_success' and test case
> description for last test. Without this, we get:
>
> t4002-diff-basic.sh: line 412: test_expect_successdiff can read from stdin: command not found
>
> Signed-off-by: Andreas Herrmann <aherrmann@suse.de>

Thanks for finding this problem and submitting a fix. You're the second person to do so[1].

[1]: https://lore.kernel.org/git/pull.1545.git.git.1689341410476.gitgitgadget@gmail.com/

Show 8 quoted lines

> diff --git a/t/t4002-diff-basic.sh b/t/t4002-diff-basic.sh
> @@ -401,9 +401,10 @@ test_expect_success 'diff-tree B A == diff-tree -R A B' '
>  test_expect_success 'diff-tree -r B A == diff-tree -r -R A B' '
>         git diff-tree -r $tree_B $tree_A >.test-a &&
>         git diff-tree -r -R $tree_A $tree_B >.test-b &&
> -       cmp -s .test-a .test-b'
> +       cmp -s .test-a .test-b
> +'

This minor style fixup could be resubmitted as a standalone patch, though it might be too minor to worry about.

Show 5 quoted lines

> -test_expect_success'diff can read from stdin' '
> +test_expect_success 'diff can read from stdin' '
>         test_must_fail git diff --no-index -- MN - < NN |
>                 grep -v "^index" | sed "s#/-#/NN#" >.test-a &&
>         test_must_fail git diff --no-index -- MN NN |