Re: [PATCH 1/4] odb: store ODB source in `struct odb_transaction`

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 29, 2026, 20:28 UTC
Message-ID: <xmqqwm109n97.fsf@gitster.g>
In-Reply-To: <aXu4nttn-SWcMmLL@denethor>

Justin Tobler <jltobler@gmail.com> writes:

Show 7 quoted lines

> Interestingly, it looks like there are only three users of odb-tmpdir:
> remerge-diffs, git-recieve-pack, and ODB transactions. All of these
> use-cases seems like a reasonble fit to create an ODB transaction
> instead of managing the tmpdir directly. In the case of remerge-diffs
> the transaction would need to always be aborted. If this is done, then a
> tmpdir could become an internal detail of the ODB transaction for the
> files backend.

;-)  I agree 100%.

"Prepare to create objects that may be undone in the end", "Now make these objects we created so far as parmanent part of the object store", "Reject those objects we created so far as the transaction created them is being aborted" are requests at the right abstraction level. "Give me a temporary object directory" is not.