Re: [PATCH v4 0/2] graph: indent visual roots in graph
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 13, 2026, 03:01 UTC
- Message-ID
- <xmqqwlw3f8ir.fsf@gitster.g>
- In-Reply-To
- <20260612-ps-pre-commit-indent-v4-0-e8492037ebae@gmail.com>
Pablo Sabater <pabloosabaterr@gmail.com> writes:
Show 17 quoted lines
> When rendering a graph, if the history contains multiple "visual roots", > actual roots or commits that look like roots (i.e. have their parents > filtered out) can end up being vertically adjacent to unrelated commits, > falsely appearing to be related. > ... > [1]: https://lore.kernel.org/git/xmqqwnwajbuj.fsf@gitster.c.googlers.com/ > > V3 DIFF: > > - Completly changes the approach to indent the visual roots instead of the > commits after the visual roots. > > Signed-off-by: Pablo Sabater <pabloosabaterr@gmail.com> > --- > Pablo Sabater (2): > lib-log-graph: move check_graph function > graph: indent visual root in graph
The new tests added here does not seem to play well with linux-TEST-vars CI job when merged to 'seen' or 'jch' with other topics in flight.
https://github.com/git/git/actions/runs/27445164550/job/81128391150#step:10:1779 https://github.com/git/git/actions/runs/27445164037/job/81128386244#step:10:1778
I suspect that these tests are failing the same way even standalone.
https://github.com/git/git/actions/runs/27447146727/job/81134594264#step:9:2136