Re: [PATCH v10 7/7] graph: add --[no-]graph-indent and log.graphIndent
On Mon, Jul 13, 2026 at 12:44:42PM +0200, Pablo Sabater wrote:
Show 17 quoted lines
> Some users may prefer to not have graph indentation.
>
> Add "log.graphIndent" config variable to graph_read_config() to read the
> default preference. By default is graph indentation is true.
>
> Add --graph-indent and --no-graph-indent options to overwrite the
> default preference.
>
> Signed-off-by: Pablo Sabater <pabloosabaterr@gmail.com>
> ---
> Documentation/config/log.adoc | 4 +++
> Documentation/rev-list-options.adoc | 8 ++++++
> graph.c | 10 +++++--
> revision.c | 9 +++++++
> revision.h | 2 ++
> t/t4218-log-graph-indentation.sh | 52 +++++++++++++++++++++++++++++++++++++
> 6 files changed, 83 insertions(+), 2 deletions(-)
Show 10 quoted lines
> diff --git a/revision.h b/revision.h
> index 569b3fa1cb..49e1380b80 100644
> --- a/revision.h
> +++ b/revision.h
> @@ -314,6 +314,8 @@ struct rev_info {
> /* Display history graph */
> struct git_graph *graph;
> int graph_max_lanes;
> + int no_graph_indent;
> + unsigned int graph_indent_set;These are both boolean values and could be set to be 1 bit wide.
Other than that LGTM.
Thank you for the changes.