git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [Outreachy PATCH] merge-blobs: stop using the_repository

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 20, 2026, 21:54 UTC
Message-ID
<xmqqwlrcrqaz.fsf@gitster.g>
In-Reply-To
<CAPSxiM-OyrVEzYgja0nwa8PikfU1WpsCYbiNiXpcxb4TM4=mOA@mail.gmail.com>
Usman Akinyemi <usmanakinyemi202@gmail.com> writes:
Show 7 quoted lines
>> +static int fill_mmfile_blob(struct repository *r, mmfile_t *f,
>> +                           struct blob *obj)
>
> Is there a reason why the repo variable is named "r" instead of repo ?
>
> "repo" seems more "descriptive" than "r". if there is no reason, let's change
> it to "repo" from "r"
Is that really needed?

I thought that we already use short-and-sweet "r" elsewhere, and it is expected we will have many more functions that take "struct repository *" as the first parameter as the libification stuff goes further, so if we consistently say "r", that would be just familiar and descriptive as "repository" to our developers, without risking to make readers wonder what "repo" stands for, things other than "repository", like "reposses" ;-).

Previous: Okhuomon AjayiNext: Usman Akinyemi
Message 4 of 6 in “merge-blobs: stop using the_repository”
  1. merge-blobs: stop using the_repositoryOkhuomon Ajayi, Oct 17, 2026
  2. Usman AkinyemiOct 20, 2026
  3. Okhuomon AjayiOct 20, 2026
  4. Junio C HamanoOct 20, 2026
  5. Usman AkinyemiOct 20, 2026
  6. Junio C HamanoNov 7, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.