From: Junio C Hamano Date: Tue, 20 Oct 2026 21:54:28 GMT Subject: Re: [Outreachy PATCH] merge-blobs: stop using the_repository Message-ID: In-Reply-To: Usman Akinyemi writes: >> +static int fill_mmfile_blob(struct repository *r, mmfile_t *f, >> + struct blob *obj) > > Is there a reason why the repo variable is named "r" instead of repo ? > > "repo" seems more "descriptive" than "r". if there is no reason, let's change > it to "repo" from "r" Is that really needed? I thought that we already use short-and-sweet "r" elsewhere, and it is expected we will have many more functions that take "struct repository *" as the first parameter as the libification stuff goes further, so if we consistently say "r", that would be just familiar and descriptive as "repository" to our developers, without risking to make readers wonder what "repo" stands for, things other than "repository", like "reposses" ;-).