Re: [PATCH] blame.c: prepare_lines should not call xrealloc for every line
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 4, 2014, 21:41 UTC
- Message-ID
- <xmqqvbwu7dya.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <878utqwpkx.fsf@fencepost.gnu.org>
David Kastrup <dak@gnu.org> writes:
Show 15 quoted lines
> Junio C Hamano <gitster@pobox.com> writes: > >> David Kastrup <dak@gnu.org> writes: >> >>> Anybody know offhand what I should be including here? It looks like Git >>> has some fallback definitions of its own, so it's probably not just >>> <string.h> I should include? >> >> In general, no *.c files outside the compatibility layer should >> include anything "#include <system-header.h>", as there seem to be >> finicky systems that care about order of inclusion and feature macro >> definitions, all of which are meant to be handled by including >> git-compat-util.h as the very first thing. > > Ok, and that one's not yet in blame.c. Will include, thanks.
No, don't. Some well-known *.h files of ourse, most notably cache.h, are known to include compat-util as the first thing, and that is what *.c files typically include.