Re: [PATCH] blame.c: prepare_lines should not call xrealloc for every line

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 5, 2014, 20:34 UTC
Message-ID: <xmqqob2l2ta7.fsf@gitster.dls.corp.google.com>
In-Reply-To: <87r47hvrqt.fsf@fencepost.gnu.org>

David Kastrup <dak@gnu.org> writes:

Show 17 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
>
>> which I think is the prevalent style in our codebase.  The same for
>> the other loop we see in the new code below.
>>
>>  - avoid assignments in conditionals when you do not have to.
>
> commit a77a48c259d9adbe7779ca69a3432e493116b3fd
> Author: Junio C Hamano <gitster@pobox.com>
> Date:   Tue Jan 28 13:55:59 2014 -0800
>
>     combine-diff: simplify intersect_paths() further
> [...]
>
> +       while ((p = *tail) != NULL) {
>
> Because we can.

Be reasonable.  You cannot sensibly rewrite it to

	p = *tail;
        while (p) {
        	...
		p = *tail;
	}

when you do not know how ... part would evolve in the future.

	if ((p = *tail) != NULL) {
        	...

is a totally different issue.