Re: [PATCH] wt-status: i18n of section labels

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 13, 2014, 18:01 UTC
Message-ID: <xmqqvbviht9r.fsf@gitster.dls.corp.google.com>
In-Reply-To: <5320C0DD.1090803@savoirfairelinux.com>

Sandy Carter <sandy.carter@savoirfairelinux.com> writes:

Show 11 quoted lines

> I refered to the wrong lines, the ones I was refering to were:
>
>> +static int maxwidth(const char *(*label)(int), int minval, int maxval)
>> +{
>> +	int result = 0, i;
>> +
>> +	for (i = minval; i <= maxval; i++) {
>> +		const char *s = label(i);
>> +		int len = s ? utf8_strwidth(s) : 0;
>
> Sorry about that

Oh, yes, you are right. wt_status_diff_status_string() is meant to be asked with a bogus status character and expected to return NULL, so diagnosing anything it does not understand as a "bug" is indeed a bug I added.

I think I fixed in my latest reroll ($gmane/243996).

Thanks for catching that.