Re: [PATCH v7 0/1] refs.c: SSE4.2 optimizations for check_refname_component

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 9, 2014, 23:05 UTC
Message-ID: <xmqqvbs9d6qn.fsf@gitster.dls.corp.google.com>
In-Reply-To: <xmqqfvjdenk5.fsf@gitster.dls.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 13 quoted lines

> David Turner <dturner@twopensource.com> writes:
>
>> Since Junio has picked up the first patch from previous versions of
>> this series, I'm just going to send the second (SSE) one.  I decided
>> not to s/NO_SSE42/!HAVE_SSE42/ because it looks like git mostly uses
>> the former convention (for instance, that's what GIT_PARSE_WITH
>> generates).
>
> Yeah but NO_FROTZ is used only when FROTZ is something everybody is
> expected to have (e.g. it's in posix, people ought to have it, but
> we do support those who don't), isn't it?  For a very arch specific
> stuff like sse42, I'd feel better to make it purely opt-in by
> forcing people to explicitly say HAVE_SSE42 to enable it.

Just FYI: I am getting

compat/cpuid.h:8:12: error: 'processor_supports_sse42' defined but not used [-Werror=unused-function] cc1: all warnings being treated as errors

while building 'pu'; I'll have to rebuild 'pu' without this patch before I can push the day's result out.