Re: [PATCH v7 0/1] refs.c: SSE4.2 optimizations for check_refname_component

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 10, 2014, 06:55 UTC
Message-ID: <xmqqfvjdb6en.fsf@gitster.dls.corp.google.com>
In-Reply-To: <53969FDF.3050506@viscovery.net>

Johannes Sixt <j.sixt@viscovery.net> writes:

Show 17 quoted lines

> And I get this when I compile on Windows with msysgit:
>
>     CC abspath.o
> In file included from git-compat-util.h:694,
>                  from cache.h:4,
>                  from abspath.c:1:
> compat/cpuid.h: In function 'processor_supports_sse42':
> compat/cpuid.h:11: warning: implicit declaration of function '__cpuid'
> abspath.c: At top level:
> compat/cpuid.h:8: warning: 'processor_supports_sse42' defined but not used
> abspath.c: In function 'processor_supports_sse42':
> compat/cpuid.h:11: warning: 'eax' is used uninitialized in this function
> compat/cpuid.h:11: warning: 'ebx' is used uninitialized in this function
> compat/cpuid.h:11: warning: 'ecx' is used uninitialized in this function
> compat/cpuid.h:11: warning: 'edx' is used uninitialized in this function
>
> Perhaps our gcc is too old?

Maybe.

In any case, it is a good indication that it probably is a good idea to start with an optional USE_SSE42 (not !NO_SSE42 or HAVE_SSE42) so that it is clear to anybody that those with SSE42 does not have to use this compilation option. Once the code proves itself, we can consider turning it on by default when able, but it seems that it is a bit too premature for that (not that the code itself is premature in the original author's environment, but its portability has not been quite ready for everybody yet, it seems).