Re: [PATCH 1/3] tag: use skip_prefix instead of magic numbers

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 11, 2014, 18:42 UTC
Message-ID: <xmqqvbr33ff0.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20140711175056.GE7856@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 9 quoted lines

> On Fri, Jul 11, 2014 at 10:24:05AM -0700, Jacob Keller wrote:
>
>> Make the parsing of the --sort parameter more readable by having
>> skip_prefix keep our pointer up to date.
>> 
>> Authored-by: Jeff King <peff@peff.net>
>
> I suspect Junio may just apply this on the version of the commit he has
> upstream, so you may not need this as part of your series.

You read me correctly ;-) That is what I was planning to do, to fork jk/tag-sort topic on top of the updated jk/skip-prefix topic.

Show 6 quoted lines

> However, for reference, the right way to handle authorship is with a
>
>   From: Jeff King <peff@peff.net>
>
> at the top of your message body. Git-am will pick that up and turn it
> into the author field of the commit.

Thanks.