Re: [PATCH 3/3 v5] tag: support configuring --sort via .gitconfig

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 13, 2014, 17:01 UTC
Message-ID: <xmqqk37h19dc.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20140712011735.GB17349@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 15 quoted lines

> On Fri, Jul 11, 2014 at 02:54:25PM -0700, Junio C Hamano wrote:
>
>> > Yeah, we're quite inconsistent there. In some cases we silently ignore
>> > something unknown (e.g., a color.diff.* slot that we do not understand),
>> > but in most cases if it is a config key we understand but a value we do
>> > not, we complain and die.
>> 
>> Hm, that's bad---we've become less and less careful over time,
>> perhaps?
>
> I don't think so. I think we've always been not-very-lenient with
> parsing values. Two examples:
> ...
> So I do not think we have ever had a rule, but if we did, it is probably
> "silently ignore unknown keys, complain on unknown values".

Yeah, somehow I was mixing up these two cases fuzzily in my mind while responding. Rejecting unknown keys is bad, but we cannot be perfectly forward compatible nor behave sensibly on unknown values while issuing errors against known-to-be-bad values, so your rule above sounds like the most sensible thing to do.