git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] strbuf: export strbuf_addchars()

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 8, 2014, 18:32 UTC
Message-ID
<xmqqvboym09h.fsf@gitster.dls.corp.google.com>
In-Reply-To
<540C0344.9060002@web.de>
René Scharfe <l.s.r@web.de> writes:
> Move strbuf_addchars() to strbuf.c, where it belongs, and make it
> available for other callers.
>
> Signed-off-by: Rene Scharfe <l.s.r@web.de>
Wow, fixing up v1.7.0.2~9^2~2?

Both patches look correct, but I have to wonder where you are drawing these clean-up opportunities from? Almost as if reading through dormant part of the codebase one of your hobbies or something ;-)

Jokes aside, I very much appreciate it.  Thanks.
Previous: René ScharfeNext: René Scharfe
Message 3 of 4 in “strbuf: export strbuf_addchars()”
  1. 1/2 strbuf: export strbuf_addchars()René Scharfe, Sep 7, 2014
  2. 2/2 strbuf: use strbuf_addchars() for adding a char multiple timesRené Scharfe, Sep 7, 2014
  3. Junio C HamanoSep 8, 2014
  4. René ScharfeSep 8, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.