git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] strbuf: export strbuf_addchars()

From
René Scharfe <l.s.r@web.de>
Date
Sep 8, 2014, 21:36 UTC
Message-ID
<540E214B.3060400@web.de>
In-Reply-To
<xmqqvboym09h.fsf@gitster.dls.corp.google.com>
Am 08.09.2014 um 20:32 schrieb Junio C Hamano:
Show 8 quoted lines
> René Scharfe <l.s.r@web.de> writes:
>
>> Move strbuf_addchars() to strbuf.c, where it belongs, and make it
>> available for other callers.
>>
>> Signed-off-by: Rene Scharfe <l.s.r@web.de>
>
> Wow, fixing up v1.7.0.2~9^2~2?
About time, isn't it? ;)
> Both patches look correct, but I have to wonder where you are
> drawing these clean-up opportunities from?  Almost as if reading
> through dormant part of the codebase one of your hobbies or
> something ;-)

That, and I'm sitting on a pile of cleanup patches that grew whenever I looked at some piece of code for the first time, e.g. due to bug reports, or when I took a static analyzer for a test drive etc. I'm trying to filter out the good ones and to send them at opportune moments in order to avoid conflicts with real changes.

René
Previous: Junio C Hamano
Message 4 of 4 in “strbuf: export strbuf_addchars()”
  1. 1/2 strbuf: export strbuf_addchars()René Scharfe, Sep 7, 2014
  2. 2/2 strbuf: use strbuf_addchars() for adding a char multiple timesRené Scharfe, Sep 7, 2014
  3. Junio C HamanoSep 8, 2014
  4. René ScharfeSep 8, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.